You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/07/08 23:47:14 UTC

[jira] Created: (WINK-62) Provide a suggested Eclipse code formatter

Provide a suggested Eclipse code formatter
------------------------------------------

                 Key: WINK-62
                 URL: https://issues.apache.org/jira/browse/WINK-62
             Project: Wink
          Issue Type: Improvement
          Components: Documentation
            Reporter: Bryant Luk


Provide a suggested Eclipse code formatter.

This is obviously not a hard requirement as all patches are welcome and other IDEs are used and is only a suggestion.  I'll attach a sample codestyle (Eclipse 3.4, should be compatible with most Eclipse releases I hope) that is taken from Tuscany ( https://svn.apache.org/repos/asf/tuscany/java/etc/ ) as suggested by Luciano Resende.

However, there are 2 changes that I made:

1)  Use a code line width of 100 (instead of Tuscany's 120).  (Splits the difference between 80 and 120).
2)  "Align fields in columns." is checked.

Please add a comment to this JIRA if you want something changed.  I'll leave this open for someone else to commit to get at least one other person to check this out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WINK-62) Provide a suggested Eclipse code formatter

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk closed WINK-62.
--------------------------


> Provide a suggested Eclipse code formatter
> ------------------------------------------
>
>                 Key: WINK-62
>                 URL: https://issues.apache.org/jira/browse/WINK-62
>             Project: Wink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.1
>
>         Attachments: wink-eclipse-codestyle.xml
>
>
> Provide a suggested Eclipse code formatter.
> This is obviously not a hard requirement as all patches are welcome and other IDEs are used and is only a suggestion.  I'll attach a sample codestyle (Eclipse 3.4, should be compatible with most Eclipse releases I hope) that is taken from Tuscany ( https://svn.apache.org/repos/asf/tuscany/java/etc/ ) as suggested by Luciano Resende.
> However, there are 2 changes that I made:
> 1)  Use a code line width of 100 (instead of Tuscany's 120).  (Splits the difference between 80 and 120).
> 2)  "Align fields in columns." is checked.
> Please add a comment to this JIRA if you want something changed.  I'll leave this open for someone else to commit to get at least one other person to check this out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WINK-62) Provide a suggested Eclipse code formatter

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk updated WINK-62:
---------------------------

    Attachment: wink-eclipse-codestyle.xml

> Provide a suggested Eclipse code formatter
> ------------------------------------------
>
>                 Key: WINK-62
>                 URL: https://issues.apache.org/jira/browse/WINK-62
>             Project: Wink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Bryant Luk
>         Attachments: wink-eclipse-codestyle.xml
>
>
> Provide a suggested Eclipse code formatter.
> This is obviously not a hard requirement as all patches are welcome and other IDEs are used and is only a suggestion.  I'll attach a sample codestyle (Eclipse 3.4, should be compatible with most Eclipse releases I hope) that is taken from Tuscany ( https://svn.apache.org/repos/asf/tuscany/java/etc/ ) as suggested by Luciano Resende.
> However, there are 2 changes that I made:
> 1)  Use a code line width of 100 (instead of Tuscany's 120).  (Splits the difference between 80 and 120).
> 2)  "Align fields in columns." is checked.
> Please add a comment to this JIRA if you want something changed.  I'll leave this open for someone else to commit to get at least one other person to check this out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WINK-62) Provide a suggested Eclipse code formatter

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729197#action_12729197 ] 

Jason Dillon commented on WINK-62:
----------------------------------

As I use IDEA it won't matter much to me.  Though if you really want to control the style of the code, then the checkstyle plugin can be configured.  But, for other larger projects (like Geronimo) we avoided this, just providing some simple guidelines.  It would be a mess of build errors to enable checkstyle to be the code-style nazi.

> Provide a suggested Eclipse code formatter
> ------------------------------------------
>
>                 Key: WINK-62
>                 URL: https://issues.apache.org/jira/browse/WINK-62
>             Project: Wink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Bryant Luk
>         Attachments: wink-eclipse-codestyle.xml
>
>
> Provide a suggested Eclipse code formatter.
> This is obviously not a hard requirement as all patches are welcome and other IDEs are used and is only a suggestion.  I'll attach a sample codestyle (Eclipse 3.4, should be compatible with most Eclipse releases I hope) that is taken from Tuscany ( https://svn.apache.org/repos/asf/tuscany/java/etc/ ) as suggested by Luciano Resende.
> However, there are 2 changes that I made:
> 1)  Use a code line width of 100 (instead of Tuscany's 120).  (Splits the difference between 80 and 120).
> 2)  "Align fields in columns." is checked.
> Please add a comment to this JIRA if you want something changed.  I'll leave this open for someone else to commit to get at least one other person to check this out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WINK-62) Provide a suggested Eclipse code formatter

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk resolved WINK-62.
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.1
         Assignee: Bryant Luk

I went ahead and attached a suggested code style to:
http://cwiki.apache.org/confluence/display/WINK/Coding+Guidelines

I don't think we need to use checkstyle right now.  I don't see many massive diffs that change lines for no apparent reason.

> Provide a suggested Eclipse code formatter
> ------------------------------------------
>
>                 Key: WINK-62
>                 URL: https://issues.apache.org/jira/browse/WINK-62
>             Project: Wink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.1
>
>         Attachments: wink-eclipse-codestyle.xml
>
>
> Provide a suggested Eclipse code formatter.
> This is obviously not a hard requirement as all patches are welcome and other IDEs are used and is only a suggestion.  I'll attach a sample codestyle (Eclipse 3.4, should be compatible with most Eclipse releases I hope) that is taken from Tuscany ( https://svn.apache.org/repos/asf/tuscany/java/etc/ ) as suggested by Luciano Resende.
> However, there are 2 changes that I made:
> 1)  Use a code line width of 100 (instead of Tuscany's 120).  (Splits the difference between 80 and 120).
> 2)  "Align fields in columns." is checked.
> Please add a comment to this JIRA if you want something changed.  I'll leave this open for someone else to commit to get at least one other person to check this out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.