You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Michael Park (JIRA)" <ji...@apache.org> on 2017/12/05 19:01:01 UTC

[jira] [Commented] (MESOS-6972) Improve performance of protobuf message passing by removing RepeatedPtrField to vector conversion.

    [ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279048#comment-16279048 ] 

Michael Park commented on MESOS-6972:
-------------------------------------

{noformat}
commit 8670d2e9224485b94a40654d4a2102d8340fe4ac (private/ci/mpark/utility, ci/mpark/utility)
Author: Michael Park <mp...@apache.org>
Date:   Mon Dec 4 17:25:36 2017 -0800

    Added `lambda::partial` to <stout/lambda.hpp>.

    Review: https://reviews.apache.org/r/64274/
{noformat}
{noformat}
commit 3b9db404cb0b50edef1958423b26364e63ccaa27
Author: Michael Park <mp...@apache.org>
Date:   Mon Dec 4 17:25:33 2017 -0800

    Added `cpp17::invoke` in <stout/cpp17.hpp>.

    Review: https://reviews.apache.org/r/64248/
{noformat}

> Improve performance of protobuf message passing by removing RepeatedPtrField to vector conversion.
> --------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-6972
>                 URL: https://issues.apache.org/jira/browse/MESOS-6972
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Benjamin Mahler
>              Labels: performance, tech-debt
>
> Currently, all protobuf message handlers must take a {{vector}} for repeated fields, rather than a {{RepeatedPtrField}}.
> This requires that a copy be performed of the repeated field's entries (see [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]), which can be very expensive in some cases. We should avoid requiring this expense on the callers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)