commit-email.pl directory collapsing broken

[Blair Zajac <bl...@orcaware.com>]

I noticed that the code in commit-email.pl to collapse the list of
modified directories that should collapse a subject line from

    rev 4 - trunk/apache_configparser trunk/apache_configparser/t
    trunk/apache_configparser/lib/Apache

to

    rev 4 - in trunk/apache_configparser: t lib/Apache

never runs because this code will always evaluate @commonpieces
to 0:

    # collapse the list of changed directories
    my @commonpieces = ();
    my $commondir = '';
    if (($rootchanged == 0) and (scalar @commonpieces > 1))
    .
    .
    .
    }

If this is changed, then there's still another bug that would leave
the common directory in the list of modified directories, like this:

    rev 4 - in trunk/apache_configparser: trunk/apache_configparser t
    lib/Apache

Do people want this fixed?  It'll shorten the email subjects, but
I don't know if anybody wants it the way it currently is, for
parsing purposes, etc.

Blair

-- 
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: commit-email.pl directory collapsing broken

[Karl Fogel <kf...@newton.ch.collab.net>]

Blair Zajac <bl...@orcaware.com> writes:
> If this is changed, then there's still another bug that would leave
> the common directory in the list of modified directories, like this:
> 
>     rev 4 - in trunk/apache_configparser: trunk/apache_configparser t
>     lib/Apache
> 
> Do people want this fixed?  It'll shorten the email subjects, but
> I don't know if anybody wants it the way it currently is, for
> parsing purposes, etc.

FWIW, I'd guess there's very little automatic parsing of these dir
lists, or anyway not parsing of more than one component at a time.

(And cvs2cl.pl, a CVS->ChangeLog script, has been doing directory
collapsing for ages, no one's ever complained.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org