You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:45:14 UTC
[GitHub] [doris] platoneko opened a new pull request, #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
platoneko opened a new pull request, #15519:
URL: https://github.com/apache/doris/pull/15519
# Proposed changes
Issue Number: close #xxx
## Problem summary
1. Unify redundant `create_rowset_writer` methods.
2. Set `resource_id` when setting `fs` in rowset meta
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15519:
URL: https://github.com/apache/doris/pull/15519#issuecomment-1367787415
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15519:
URL: https://github.com/apache/doris/pull/15519#issuecomment-1367777359
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15519:
URL: https://github.com/apache/doris/pull/15519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15519:
URL: https://github.com/apache/doris/pull/15519#issuecomment-1367791740
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15519:
URL: https://github.com/apache/doris/pull/15519#issuecomment-1367870522
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.86 seconds
load time: 703 seconds
storage size: 17123152266 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221230112939_clickbench_pr_71909.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15519:
URL: https://github.com/apache/doris/pull/15519#discussion_r1059326105
##########
be/test/olap/rowid_conversion_test.cpp:
##########
@@ -54,8 +55,6 @@ class TestRowIdConversion : public testing::TestWithParam<std::tuple<KeysType, b
}
EXPECT_TRUE(FileUtils::create_dir(absolute_dir).ok());
EXPECT_TRUE(FileUtils::create_dir(absolute_dir + "/tablet_path").ok());
- _data_dir = std::make_unique<DataDir>(absolute_dir);
- _data_dir->update_capacity();
doris::EngineOptions options;
k_engine = new StorageEngine(options);
StorageEngine::_s_instance = k_engine;
Review Comment:
warning: '_s_instance' is a private member of 'doris::StorageEngine' [clang-diagnostic-error]
```cpp
StorageEngine::_s_instance = k_engine;
^
```
**be/src/olap/storage_engine.h:321:** declared private here
```cpp
d;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15519:
URL: https://github.com/apache/doris/pull/15519#issuecomment-1367783573
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15519: [enhancement](tablet) Unify redundant `create_rowset_writer` methods
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15519:
URL: https://github.com/apache/doris/pull/15519#discussion_r1059321507
##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -54,8 +55,6 @@ class VerticalCompactionTest : public ::testing::Test {
}
EXPECT_TRUE(FileUtils::create_dir(absolute_dir).ok());
EXPECT_TRUE(FileUtils::create_dir(absolute_dir + "/tablet_path").ok());
- _data_dir = std::make_unique<DataDir>(absolute_dir);
- _data_dir->update_capacity();
doris::EngineOptions options;
k_engine = new StorageEngine(options);
StorageEngine::_s_instance = k_engine;
Review Comment:
warning: '_s_instance' is a private member of 'doris::StorageEngine' [clang-diagnostic-error]
```cpp
StorageEngine::_s_instance = k_engine;
^
```
**be/src/olap/storage_engine.h:321:** declared private here
```cpp
d;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org