You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Matthew Windwer (JIRA)" <ji...@apache.org> on 2012/09/06 19:47:08 UTC

[jira] [Created] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Matthew Windwer created CB-1381:
-----------------------------------

             Summary: 2.1.0rc2 upgrade issues (iOS)
                 Key: CB-1381
                 URL: https://issues.apache.org/jira/browse/CB-1381
             Project: Apache Cordova
          Issue Type: Bug
          Components: Docs, iOS
    Affects Versions: 2.1.0
         Environment: iOS
            Reporter: Matthew Windwer
            Assignee: Michael Brooks
             Fix For: 2.1.0


1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'

2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)

3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Matthew Windwer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450047#comment-13450047 ] 

Matthew Windwer commented on CB-1381:
-------------------------------------

I traced the issue regarding InAppPurchaseManager to the fact that the arguments are not being passed from the JS to the native code. I'm trying to find out what changed between 2.1 and 2.0 to determine why.  I also had to substitute JSONString with cdvjk_JSONString in the .m file.
                
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Shazron Abdullah
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shazron Abdullah reassigned CB-1381:
------------------------------------

    Assignee: Shazron Abdullah  (was: Michael Brooks)
    
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Shazron Abdullah
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449927#comment-13449927 ] 

Shazron Abdullah commented on CB-1381:
--------------------------------------

Not sure - the plugin author is trying to be clever here, they are not even including JSONKit.h
                
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Shazron Abdullah
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449895#comment-13449895 ] 

Shazron Abdullah commented on CB-1381:
--------------------------------------

Thanks Matthew, good catches.

1) Will update the docs
2) Hmm I wonder why it didn't complain about AppDelegate.m and MainViewController.m not being ARC. But it definitely is on I tested (#if __has_feature(objc_arc) is true) just in case. Will fix.
3) Right now there is no place for Plugin Upgrade Guides in docs.phonegap.com - the iOS Plugin Upgrade Guide regarding JSONKit is in the "Cordova Plugin Upgrade Guide.md" document in the "guides" sub-folder of the iOS source distribution CB-1000
                
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Michael Brooks
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shazron Abdullah resolved CB-1381.
----------------------------------

    Resolution: Fixed

1. Fix commit - http://git-wip-us.apache.org/repos/asf/incubator-cordova-docs/commit/27080796
2. Fix commit - http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/d4db3809

                
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Shazron Abdullah
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1381) 2.1.0rc2 upgrade issues (iOS)

Posted by "Matthew Windwer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449904#comment-13449904 ] 

Matthew Windwer commented on CB-1381:
-------------------------------------

Thanks. Regarding #3 I looked at the plugin upgrade guide and am still unsure how to go about fixing:
https://github.com/phonegap/phonegap-plugins/blob/master/iOS/InAppPurchaseManager/InAppPurchaseManager.m

I'm not an Objective-C programmer, so would appreciate any insight!
                
> 2.1.0rc2 upgrade issues (iOS)
> -----------------------------
>
>                 Key: CB-1381
>                 URL: https://issues.apache.org/jira/browse/CB-1381
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs, iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Matthew Windwer
>            Assignee: Shazron Abdullah
>             Fix For: 2.1.0
>
>
> 1) AppDelegate.m needs to be updated when upgrading from 2.0 to 2.1... this is not yet in the upgrade guide. Otherwise you will run into "Property 'supportedOrientations' not found on object of type 'CDVViewController*'
> 2) ARC is currently turned ON by default when creating a new project with the create script on 2.1.0rc2. This is not expected and breaks many plugins. (Objective-C Automatic Reference Counting defaults to "Yes" in project Build Settings)
> 3) Something about the upgrade from 2.0 to 2.1 broke the InAppPurchaseMangager plugin for me... I would really appreciate if somebody can point me in the right direction to fix this, I filed an issue here: https://github.com/phonegap/phonegap-plugins/issues/779. This may be related to the internal JSONKit renaming [CB-1000] and [CB-1105] but I'm not sure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira