You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/09 13:58:18 UTC

[GitHub] azagrebin opened a new pull request #7073: [FLINK-10842][E2E tests] fix broken waiting loops in common.sh

azagrebin opened a new pull request #7073: [FLINK-10842][E2E tests] fix broken waiting loops in common.sh
URL: https://github.com/apache/flink/pull/7073
 
 
   ## What is the purpose of the change
   
   There are 3 loops in flink-end-to-end-tests/test-scripts/common.sh where the script waits for some event to happen (for i in {1..10}; do):
   
   wait_dispatcher_running
   start_and_wait_for_tm
   wait_job_running
   
   This PR changes them to fail if the expected event has not happened and to return from the loop if happened.
   
   ## Brief change log
   
     - change waiting loops in common.sh
   
   ## Verifying this change
   
   Run any relevant e2e tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services