You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/09 05:29:19 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #13811: Add erfinv operator for calculating inverse error function

eric-haibin-lin commented on a change in pull request #13811: Add erfinv operator for calculating inverse error function
URL: https://github.com/apache/incubator-mxnet/pull/13811#discussion_r246263453
 
 

 ##########
 File path: src/operator/mshadow_op.h
 ##########
 @@ -169,6 +169,93 @@ struct softrelu : public mxnet_op::tunable {
 
 MXNET_UNARY_MATH_OP(softrelu_grad, -math::expm1(-a));
 
+
+/* The next function is taken from 
 
 Review comment:
   Can we create a file `src/operator/contrib/erfinv-inl.h`, include `src/operator/mshadow_op.h` and move the license and implementation of L172 - L257 there? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services