You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/08 19:27:53 UTC

[GitHub] [druid] gianm commented on pull request #11886: RowBasedSegment: Use Sequence instead of Iterable.

gianm commented on pull request #11886:
URL: https://github.com/apache/druid/pull/11886#issuecomment-963499828


   In this patch, I added an extra state validation to `RowWalker.advance` making sure that `!isDone()`. This caused a test failure in CalciteQueryTest.testFilterAndGroupByLookupUsingJoinOperatorBackwards, revealing a bug in HashJoinEngine. I'll fix that in a separate PR, which will have to go in before this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org