You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:59:23 UTC

[GitHub] [maven-shade-plugin] JanMosigItemis commented on pull request #83: [MSHADE-366] - "Access denied" during 'minimizeJar'

JanMosigItemis commented on pull request #83:
URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-847642859


   Hi @kriegaex and thanks for your input. I totally understand your remark on code readability but I've got a totally different opinion which is why I provided the PR as I did. This does also hold for usage of `new File..` vs. `Files..`. 
   
   Also I once was taught to avoid `continue` (or `break` for that matter) in loops bc it makes the execution path harder to be traced.
   
   Anyway, I'd oblige to any code style the maintainers see fit and would also happily alter (and rebase) the PR if need be. A new PR would also be ok with me, I really do only care about this nasty warning going away.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org