[GitHub] [flink] JingsongLi commented on a change in pull request #9208: [FLINK-13378][table-planner-blink] Fix bug: Blink-planner not support SingleValueAggFunction

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #9208: [FLINK-13378][table-planner-blink] Fix bug: Blink-planner not support SingleValueAggFunction
URL: https://github.com/apache/flink/pull/9208#discussion_r306642943
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/runtime/batch/sql/join/ScalarQueryITCase.scala
 ##########
 @@ -46,6 +49,18 @@ class ScalarQueryITCase extends BatchTestBase {
     row(6, null)
   )
 
-}
+  @Before
+  override def before(): Unit = {
+    super.before()
+    registerCollection("l", l, INT_DOUBLE, "a, b")
+    registerCollection("r", r, INT_DOUBLE, "c, d")
+  }
 
+  @Test
+  def testScalarQuery(): Unit = {
 
 Review comment:
   What is multiple row agg?
   You mean use SingleValueAgg directly in sql? If that is what you mean, I prefer not add. Because SingleValueAgg is just add for scalar sub query, we don't recommend user to use in sql.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services