You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by "RKuttruff (via GitHub)" <gi...@apache.org> on 2023/11/06 18:24:38 UTC
[PR] Remove chardet from images [incubator-sdap-ingester]
RKuttruff opened a new pull request, #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove chardet from images [incubator-sdap-ingester]
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on code in PR #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91#discussion_r1402414693
##########
granule_ingester/setup.py:
##########
@@ -24,7 +24,7 @@
__version__ = f.readline()
try:
- check_call(['conda', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
+ check_call(['mamba', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
Review Comment:
I've never had mamba fail, and from what I've read, if mamba doesn't work, conda won't either
I did that fallback cause I didn't know that at the time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove chardet from images [incubator-sdap-ingester]
Posted by "skorper (via GitHub)" <gi...@apache.org>.
skorper commented on code in PR #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91#discussion_r1402409860
##########
granule_ingester/setup.py:
##########
@@ -24,7 +24,7 @@
__version__ = f.readline()
try:
- check_call(['conda', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
+ check_call(['mamba', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
Review Comment:
Any reason we're not using conda if mamba fails like we do [here](https://github.com/apache/incubator-sdap-nexus/blob/master/analysis/setup.py#L24-L31)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove chardet from images [incubator-sdap-ingester]
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on code in PR #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91#discussion_r1402416969
##########
granule_ingester/setup.py:
##########
@@ -24,7 +24,7 @@
__version__ = f.readline()
try:
- check_call(['conda', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
+ check_call(['mamba', 'install', '-y', '-c', 'conda-forge', '--file', 'conda-requirements.txt'])
Review Comment:
On second thought... maybe I should still do that in the event it's being run locally w/o mamba installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove chardet from images [incubator-sdap-ingester]
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on PR #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91#issuecomment-1823161520
@skorper Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove chardet from images [incubator-sdap-ingester]
Posted by "skorper (via GitHub)" <gi...@apache.org>.
skorper merged PR #91:
URL: https://github.com/apache/incubator-sdap-ingester/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org