You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/21 22:01:01 UTC

[GitHub] [iceberg] Fokko opened a new pull request, #6478: Python: Read a date as an int

Fokko opened a new pull request, #6478:
URL: https://github.com/apache/iceberg/pull/6478

   The partitions struct will read as a date if there is a date field in there. This way we'll just read the physical type.
   
   closes #6469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #6478: Python: Read a date as an int

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6478:
URL: https://github.com/apache/iceberg/pull/6478#issuecomment-1362180551

   This looks correct to me. Can you add a test that hits this in job planning?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue merged pull request #6478: Python: Read a date as an int

Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6478:
URL: https://github.com/apache/iceberg/pull/6478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko commented on pull request #6478: Python: Read a date as an int

Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6478:
URL: https://github.com/apache/iceberg/pull/6478#issuecomment-1362225099

   @rdblue Added a test when parsing the ManifestEntry. I can add an end to end test in https://github.com/apache/iceberg/pull/6398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org