[GitHub] [spark] turboFei commented on a change in pull request #24533: [SPARK-27637] For nettyBlockTransferService, when exception occurred when fetching data, check whether relative executor is alive before retry

[GitBox <gi...@apache.org>]

turboFei commented on a change in pull request #24533: [SPARK-27637] For nettyBlockTransferService, when exception occurred when fetching data, check whether relative executor is alive  before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r281178215
 
 

 ##########
 File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java
 ##########
 @@ -178,7 +202,11 @@ private synchronized boolean shouldRetry(Throwable e) {
     boolean isIOException = e instanceof IOException
 
 Review comment:
   It's IOException, just like bellow
   ```
   2019-04-26 12:18:50,291 [26151] - WARN  [shuffle-client-4-1:TransportChannelHandler@78] - Exception in connection from hostname/ipAddress:port
   java.io.IOException: Connection reset by peer
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org