You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stormcrawler.apache.org by "omarbounawarapy (via GitHub)" <gi...@apache.org> on 2026/10/17 13:25:32 UTC
[PR] #2145 Punycode the host in politeness, partition and robots.txt keys [stormcrawler]
omarbounawarapy opened a new pull request, #2244:
URL: https://github.com/apache/stormcrawler/pull/2244
Politeness queues, partition keys and the robots.txt cache now use the punycode host from a new `URLUtil.getASCIICanonicalHost`, so `examplé.org` and `xn--exampl-gva.org` share one key, while `getCanonicalHost` and stored URLs stay as they are. @rzo1, with `opensearch.status.routing` on, a URL already stored under a Unicode host has its next status update routed to another shard, which creates a second document and leaves the old one behind (I reproduced this on OpenSearch 2.19.4 with 10 shards); is that acceptable, or does it need a note or a migration step?
Closes #2145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #2145 Punycode the host in politeness, partition and robots.txt keys [stormcrawler]
Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche commented on PR #2244:
URL: https://github.com/apache/stormcrawler/pull/2244#issuecomment-6285887906
thanks @omarbounawarapy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #2145 Punycode the host in politeness, partition and robots.txt keys [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #2244:
URL: https://github.com/apache/stormcrawler/pull/2244#issuecomment-6250205213
Thanks, looks good. On the routing question: I think that's acceptable for 4.0 and doesn't need a migration step. It only hits crawls that store Unicode hosts (the archetypes enable `hostIDNtoASCII`) and have status routing on, and #2122 already changed keys in the same way. Could you add a short note for the upgrade docs? It should cover the new routing, the `key` field in OpenSearch status documents and the `DomainParseFilter` value, which are all punycode now for these hosts.
CI fails on formatting in `HostAliasCacheKeyTest.java`. Running `mvn git-code-format:format-code -Dskip.format.code=false` fixes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #2145 Punycode the host in politeness, partition and robots.txt keys [stormcrawler]
Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche merged PR #2244:
URL: https://github.com/apache/stormcrawler/pull/2244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org