[GitHub] [spark] mridulm commented on a diff in pull request #37681: [SPARK-40235][CORE] Use interruptible lock instead of synchronized in Executor.updateDependencies()

[GitBox <gi...@apache.org>]

mridulm commented on code in PR #37681:
URL: https://github.com/apache/spark/pull/37681#discussion_r956542017


##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -969,13 +975,19 @@ private[spark] class Executor(
   /**
    * Download any missing dependencies if we receive a new set of files and JARs from the
    * SparkContext. Also adds any new JARs we fetched to the class loader.
+   * Visible for testing.
    */
-  private def updateDependencies(
+  private[spark] def updateDependencies(

Review Comment:
   nit: Is `private[executor]` not sufficient ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org