[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #281: Add FunctionConverters, FutureConverters and ObjectConverters

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #281:
URL: https://github.com/apache/incubator-pekko/pull/281#discussion_r1160034187


##########
actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/LoggingEvent.scala:
##########
@@ -15,13 +15,12 @@ package org.apache.pekko.actor.testkit.typed
 
 import java.util.Optional
 
-import scala.compat.java8.OptionConverters._
-
 import org.slf4j.Marker
 import org.slf4j.event.Level
 
 import org.apache.pekko
 import pekko.util.ccompat.JavaConverters._
+import pekko.util.OptionConverters._

Review Comment:
   So the reason why I moved these converter libraries outside of `ccompat` is that since `ccompat` is a package object it can't be accessed within Java (this was the case for `FutureConverters`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org