You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Tak Lon (Stephen) Wu (JIRA)" <ji...@apache.org> on 2018/11/08 17:15:00 UTC
[jira] [Comment Edited] (HBASE-21457)
BackupUtils#getWALFilesOlderThan refers to wrong FileSystem
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680029#comment-16680029 ]
Tak Lon (Stephen) Wu edited comment on HBASE-21457 at 11/8/18 5:14 PM:
-----------------------------------------------------------------------
{quote} + FileSystem fs = CommonFSUtils.getWALFileSystem(c);
logFiles = BackupUtils.getFiles(fs, logDir, logFiles, filter);
logFiles = BackupUtils.getFiles(fs, oldLogDir, logFiles, filter);
{quote}
can you replace filesystem parameter {{fs}} with {{walFs}} in the lines above?
In addition, can we use run this patch to master branch (I cannot find this {{BackupUtils}} class in branch-1 and branch-2) via QA-bot (I did it locally and passed) and confirm child classes of {{TestBackupBase}} passed ?
Another suggestion (optional) is to add a unit test for this function {{getWALFilesOlderThan}} in {{TestBackupUtils}} such that we can capture this behavior change.
was (Author: taklwu):
{quote} + FileSystem fs = CommonFSUtils.getWALFileSystem(c);
logFiles = BackupUtils.getFiles(fs, logDir, logFiles, filter);
logFiles = BackupUtils.getFiles(fs, oldLogDir, logFiles, filter);
{quote}
can you replace filesystem parameter {{fs}} with {{walFs}} in the lines above?
In addition, can we use run this patch to master branch via QA-bot (I did it locally and passed) and confirm child classes of {{TestBackupBase}} passed ?
Another suggestion (optional) is to add a unit test for this function {{getWALFilesOlderThan}} in {{TestBackupUtils}} such that we can capture this behavior change.
> BackupUtils#getWALFilesOlderThan refers to wrong FileSystem
> -----------------------------------------------------------
>
> Key: HBASE-21457
> URL: https://issues.apache.org/jira/browse/HBASE-21457
> Project: HBase
> Issue Type: Bug
> Reporter: Janos Gub
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21457.v1.txt
>
>
> Janos reported seeing backup test failure when testing a local HDFS for WALs while using WASB/ADLS only for store files.
> Janos spotted the code in BackupUtils#getWALFilesOlderThan which uses HBase root dir for retrieving WAL files.
> We should use the helper methods from CommonFSUtils.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)