You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (Jira)" <ji...@apache.org> on 2022/10/06 15:07:00 UTC

[jira] [Updated] (YETUS-1202) plug-ins cannot use filefilter to build lists of files

     [ https://issues.apache.org/jira/browse/YETUS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated YETUS-1202:
------------------------------------
    Issue Type: Improvement  (was: Task)

> plug-ins cannot use filefilter to build lists of files
> ------------------------------------------------------
>
>                 Key: YETUS-1202
>                 URL: https://issues.apache.org/jira/browse/YETUS-1202
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>    Affects Versions: 0.14.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>             Fix For: 0.15.0
>
>
> The core problem is that in patch mode, CHANGED_FILES is based upon the patch file.  Files that are added are still sent to filefilter in order to trigger the test.  The problem comes in that files that are added may also be excluded.  The software won't know that until the patch is applied.
> Plug-ins that absolutely, positively must keep track of files here must ALSO filter their list in patch mode.  But realistically, it would better if no such file list was kept and only used CHANGED_FILES directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)