[GitHub] [servicecomb-service-center] ChinX commented on a change in pull request #553: [SCB-1301]Change the startup process of the syncer's services for subsequent cluster management

[GitBox <gi...@apache.org>]

ChinX commented on a change in pull request #553: [SCB-1301]Change the startup process of the syncer's services for subsequent cluster management
URL: https://github.com/apache/servicecomb-service-center/pull/553#discussion_r291076016
 
 

 ##########
 File path: syncer/serf/agent.go
 ##########
 @@ -54,19 +52,12 @@ func Create(conf *Config, logOutput io.Writer) (*Agent, error) {
 }
 
 // Start agent
-func (a *Agent) Start(ctx context.Context) {
 
 Review comment:
   @tianxiaoliang The use of context here is intended to handle the graceful exit of the serf. But it has been processed in syncer/service.go (s *Server) Stop(), I don't think it is necessary to start goroutines here and repeat it. see https://github.com/apache/servicecomb-service-center/blob/master/syncer/server/server.go#L99

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services