You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/09 07:14:58 UTC
[GitHub] [spark] beliefer opened a new pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
beliefer opened a new pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164
### What changes were proposed in this pull request?
Spark SQL exists some function no elegant implementation.
For example: `BitwiseCount` override the sql method show below:
`override def sql: String = s"bit_count(${child.sql})"`
I don't think it's elegant enough.
Because `Expression` gives the following definitions.
```
def sql: String =
{ val childrenSQL = children.map(_.sql).mkString(", ") s"$prettyName($childrenSQL)" }
```
By this definition, `BitwiseCount` should override `prettyName` method.
This PR will correct the issue for some function as follows:
- `TimeWindow`
- `MaxBy`
- `MinBy`
- `UnaryMinus`
- `BitwiseCount`
### Why are the changes needed?
Improve the implement of some expression.
### Does this PR introduce any user-facing change?
'No'
### How was this patch tested?
Jenkins test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611705380
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578223
**[Test build #121142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121142/testReport)** for PR 28164 at commit [`43beb20`](https://github.com/apache/spark/commit/43beb204c028dcf97749cb4a43517d363b0d93bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611373957
**[Test build #121013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121013/testReport)** for PR 28164 at commit [`08f0906`](https://github.com/apache/spark/commit/08f0906dc0e0843abe60ace5e31fe7a64ab897bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584048
**[Test build #121144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121144/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612611409
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578358
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611371320
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612611410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121144/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612611409
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611829437
cc @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25832/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611567955
**[Test build #121036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121036/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612611176
**[Test build #121144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121144/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611371325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25704/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611567955
**[Test build #121036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121036/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612579928
**[Test build #121142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121142/testReport)** for PR 28164 at commit [`43beb20`](https://github.com/apache/spark/commit/43beb204c028dcf97749cb4a43517d363b0d93bc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611389856
**[Test build #121019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121019/testReport)** for PR 28164 at commit [`7b7f8bf`](https://github.com/apache/spark/commit/7b7f8bf5d9b2f5d929c8c9e26f76e61fe7423d6a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611390435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25710/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612579942
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611705390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121036/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612579945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121142/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611487307
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r407850469
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/MaxByAndMinBy.scala
##########
@@ -100,6 +100,9 @@ abstract class MaxMinBy extends DeclarativeAggregate {
""",
since = "3.0.0")
case class MaxBy(valueExpr: Expression, orderingExpr: Expression) extends MaxMinBy {
+
+ override def prettyName: String = "max_by"
+
override protected def funcName: String = "max_by"
Review comment:
Yes. I will replace it.
But wait for https://github.com/apache/spark/pull/28194 merged.
Then I could update golden file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611486985
**[Test build #121019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121019/testReport)** for PR 28164 at commit [`7b7f8bf`](https://github.com/apache/spark/commit/7b7f8bf5d9b2f5d929c8c9e26f76e61fe7423d6a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611568571
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611705390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121036/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611704511
**[Test build #121036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121036/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611383903
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612579942
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611383903
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578358
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25830/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611390435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25710/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611487315
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121019/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611390426
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612579945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121142/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611371320
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25832/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584048
**[Test build #121144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121144/testReport)** for PR 28164 at commit [`67c868b`](https://github.com/apache/spark/commit/67c868b64bc5727a640b27c266384598bc9f1e61).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584164
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612584164
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611487315
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121019/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25830/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611390426
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611568584
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25727/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611383872
**[Test build #121013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121013/testReport)** for PR 28164 at commit [`08f0906`](https://github.com/apache/spark/commit/08f0906dc0e0843abe60ace5e31fe7a64ab897bc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r407828550
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -43,6 +43,8 @@ case class UnaryMinus(child: Expression) extends UnaryExpression
override def toString: String = s"-$child"
+ override def prettyName: String = "-"
Review comment:
I think it should be `negative` but should show `-` when it's used as the sql operator. You should be able to do this with if-else. e.g.)
```
getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("-")
```
You might need to override `sql` IIRC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r407829666
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/MaxByAndMinBy.scala
##########
@@ -100,6 +100,9 @@ abstract class MaxMinBy extends DeclarativeAggregate {
""",
since = "3.0.0")
case class MaxBy(valueExpr: Expression, orderingExpr: Expression) extends MaxMinBy {
+
+ override def prettyName: String = "max_by"
+
override protected def funcName: String = "max_by"
Review comment:
Seems like you can remove this and replace it to `prettyName`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r407850469
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/MaxByAndMinBy.scala
##########
@@ -100,6 +100,9 @@ abstract class MaxMinBy extends DeclarativeAggregate {
""",
since = "3.0.0")
case class MaxBy(valueExpr: Expression, orderingExpr: Expression) extends MaxMinBy {
+
+ override def prettyName: String = "max_by"
+
override protected def funcName: String = "max_by"
Review comment:
Yes. I will replace it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611383913
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121013/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611389856
**[Test build #121019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121019/testReport)** for PR 28164 at commit [`7b7f8bf`](https://github.com/apache/spark/commit/7b7f8bf5d9b2f5d929c8c9e26f76e61fe7423d6a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611568571
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611568584
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25727/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#discussion_r406759268
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -43,6 +43,8 @@ case class UnaryMinus(child: Expression) extends UnaryExpression
override def toString: String = s"-$child"
+ override def prettyName: String = "-"
Review comment:
@HyukjinKwon Should we change "-" to "negative" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611383913
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121013/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611371325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25704/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28164: [SPARK-31393][SQL] Show
the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611373957
**[Test build #121013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121013/testReport)** for PR 28164 at commit [`08f0906`](https://github.com/apache/spark/commit/08f0906dc0e0843abe60ace5e31fe7a64ab897bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611705380
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28164:
[SPARK-31393][SQL] Show the correct alias in a more elegant way that
override the prettyName
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612578223
**[Test build #121142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121142/testReport)** for PR 28164 at commit [`43beb20`](https://github.com/apache/spark/commit/43beb204c028dcf97749cb4a43517d363b0d93bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-611487307
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28164: [SPARK-31393][SQL]
Show the correct alias in a more elegant way that override the prettyName
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28164: [SPARK-31393][SQL] Show the correct alias in a more elegant way that override the prettyName
URL: https://github.com/apache/spark/pull/28164#issuecomment-612611410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121144/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org