You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/03 19:37:16 UTC

[GitHub] [beam] elink21 commented on a diff in pull request #24763: Fixing python tests installations

elink21 commented on code in PR #24763:
URL: https://github.com/apache/beam/pull/24763#discussion_r1060897185


##########
.github/workflows/python_tests.yml:
##########
@@ -129,7 +129,7 @@ jobs:
       - name: Install tox
         run: pip install tox==3.27.1
       - name: Run tests basic unix
-        if: contains(matrix.os, 'ubuntu') || startsWith(matrix.os, 'macos')
+        if: contains(matrix.os, 'ubuntu-20.04') || startsWith(matrix.os, 'macos')

Review Comment:
   I've tested it with _ubuntu_, but since now the matrix.os value is an array instead of a single string, the _contains_ function doesn't trigger the test, apparently when working with arrays the function doesn't check for substrings,  only _ubuntu-20.04_ is working.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org