You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2012/01/19 14:23:11 UTC

svn commit: r1233355 - /cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java

Author: sergeyb
Date: Thu Jan 19 13:23:11 2012
New Revision: 1233355

URL: http://svn.apache.org/viewvc?rev=1233355&view=rev
Log:
[CXF-4045] Updating BusFactory to catch NoClassDefFoundError with minor refactoring to pass the Checkstyle

Modified:
    cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java

Modified: cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java
URL: http://svn.apache.org/viewvc/cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java?rev=1233355&r1=1233354&r2=1233355&view=diff
==============================================================================
--- cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java (original)
+++ cxf/trunk/api/src/main/java/org/apache/cxf/BusFactory.java Thu Jan 19 13:23:11 2012
@@ -298,25 +298,24 @@ public abstract class BusFactory {
                 busFactoryCondition = rd.readLine();
                 rd.close();
             }
-            if (isValidBusFactoryClass(busFactoryClass)) {
-                if (busFactoryCondition != null) {
-                    try {
-                        Class<?> cls =  ClassLoaderUtils.loadClass(busFactoryClass, BusFactory.class)
-                            .asSubclass(BusFactory.class);
-                        int idx = busFactoryCondition.indexOf(',');
-                        while (idx != -1) {
-                            cls.getClassLoader().loadClass(busFactoryCondition.substring(0, idx));
-                            busFactoryCondition = busFactoryCondition.substring(idx + 1);
-                            idx = busFactoryCondition.indexOf(',');
-                        }
-                        cls.getClassLoader().loadClass(busFactoryCondition);
-                        return busFactoryClass;
-                    } catch (ClassNotFoundException e) {
-                        return DEFAULT_BUS_FACTORY;
+            if (isValidBusFactoryClass(busFactoryClass) 
+                && busFactoryCondition != null) {
+                try {
+                    Class<?> cls =  ClassLoaderUtils.loadClass(busFactoryClass, BusFactory.class)
+                        .asSubclass(BusFactory.class);
+                    int idx = busFactoryCondition.indexOf(',');
+                    while (idx != -1) {
+                        cls.getClassLoader().loadClass(busFactoryCondition.substring(0, idx));
+                        busFactoryCondition = busFactoryCondition.substring(idx + 1);
+                        idx = busFactoryCondition.indexOf(',');
                     }
-                } else {
-                    return busFactoryClass;
+                    cls.getClassLoader().loadClass(busFactoryCondition);
+                } catch (ClassNotFoundException e) {
+                    busFactoryClass = DEFAULT_BUS_FACTORY;
+                } catch (NoClassDefFoundError e) {
+                    busFactoryClass = DEFAULT_BUS_FACTORY;
                 }
+                
             }
             return busFactoryClass;