You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/12/29 14:07:33 UTC

Review Request 41771: Database version check doesn't work in case of existing database from older Ambari version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41771/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.


Bugs: AMBARI-14517
    https://issues.apache.org/jira/browse/AMBARI-14517


Repository: ambari


Description
-------

Issue created on base of Apache user group conversation.
STR:
install Ambari 2.0
deploy cluster
remove ambari rpm and install Ambari 2.2 (do NOT do upgrade)
Expected result:
Database version check should throw exception about incompatible db version.

Actual result:
Guice provision exception is thrown:
26 Dec 2015 10:57:46,911 ERROR [main] AmbariServer:819 - Failed to run the Ambari Server
com.google.inject.ProvisionException: Guice provision errors:

1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
  at org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:243)
  at org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:125)
  while locating org.apache.ambari.server.api.services.AmbariMetaInfo
    for field at org.apache.ambari.server.controller.AmbariServer.ambariMetaInfo(AmbariServer.java:145)
  at org.apache.ambari.server.controller.AmbariServer.class(AmbariServer.java:145)
  while locating org.apache.ambari.server.controller.AmbariServer

1 error
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
        at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
        at org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:812)
Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.


Analisys:
According to exception it seems like Eclipselink initialize some data prior to database version check.
We should ensure db version check is first DB interaction of Ambari.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cf7194c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java c4a4e4c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 03d3661 

Diff: https://reviews.apache.org/r/41771/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 41771: Database version check doesn't work in case of existing database from older Ambari version

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41771/#review112167
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Гру. 29, 2015, 3:12 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41771/
> -----------------------------------------------------------
> 
> (Updated Гру. 29, 2015, 3:12 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-14517
>     https://issues.apache.org/jira/browse/AMBARI-14517
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Issue created on base of Apache user group conversation.
> STR:
> install Ambari 2.0
> deploy cluster
> remove ambari rpm and install Ambari 2.2 (do NOT do upgrade)
> Expected result:
> Database version check should throw exception about incompatible db version.
> 
> Actual result:
> Guice provision exception is thrown:
> 26 Dec 2015 10:57:46,911 ERROR [main] AmbariServer:819 - Failed to run the Ambari Server
> com.google.inject.ProvisionException: Guice provision errors:
> 
> 1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
>   at org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:243)
>   at org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:125)
>   while locating org.apache.ambari.server.api.services.AmbariMetaInfo
>     for field at org.apache.ambari.server.controller.AmbariServer.ambariMetaInfo(AmbariServer.java:145)
>   at org.apache.ambari.server.controller.AmbariServer.class(AmbariServer.java:145)
>   while locating org.apache.ambari.server.controller.AmbariServer
> 
> 1 error
>         at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
>         at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
>         at org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:812)
> Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
> 
> 
> Analisys:
> According to exception it seems like Eclipselink initialize some data prior to database version check.
> We should ensure db version check is first DB interaction of Ambari.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cf7194c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java c4a4e4c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 03d3661 
> 
> Diff: https://reviews.apache.org/r/41771/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 41771: Database version check doesn't work in case of existing database from older Ambari version

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41771/#review112168
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Dec. 29, 2015, 3:12 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41771/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 3:12 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-14517
>     https://issues.apache.org/jira/browse/AMBARI-14517
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Issue created on base of Apache user group conversation.
> STR:
> install Ambari 2.0
> deploy cluster
> remove ambari rpm and install Ambari 2.2 (do NOT do upgrade)
> Expected result:
> Database version check should throw exception about incompatible db version.
> 
> Actual result:
> Guice provision exception is thrown:
> 26 Dec 2015 10:57:46,911 ERROR [main] AmbariServer:819 - Failed to run the Ambari Server
> com.google.inject.ProvisionException: Guice provision errors:
> 
> 1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
>   at org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:243)
>   at org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:125)
>   while locating org.apache.ambari.server.api.services.AmbariMetaInfo
>     for field at org.apache.ambari.server.controller.AmbariServer.ambariMetaInfo(AmbariServer.java:145)
>   at org.apache.ambari.server.controller.AmbariServer.class(AmbariServer.java:145)
>   while locating org.apache.ambari.server.controller.AmbariServer
> 
> 1 error
>         at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
>         at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
>         at org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:812)
> Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
> 
> 
> Analisys:
> According to exception it seems like Eclipselink initialize some data prior to database version check.
> We should ensure db version check is first DB interaction of Ambari.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cf7194c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java c4a4e4c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 03d3661 
> 
> Diff: https://reviews.apache.org/r/41771/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 41771: Database version check doesn't work in case of existing database from older Ambari version

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41771/
-----------------------------------------------------------

(Updated Дек. 29, 2015, 3:33 п.п.)


Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.


Bugs: AMBARI-14517
    https://issues.apache.org/jira/browse/AMBARI-14517


Repository: ambari


Description
-------

Issue created on base of Apache user group conversation.
STR:
install Ambari 2.0
deploy cluster
remove ambari rpm and install Ambari 2.2 (do NOT do upgrade)
Expected result:
Database version check should throw exception about incompatible db version.

Actual result:
Guice provision exception is thrown:
26 Dec 2015 10:57:46,911 ERROR [main] AmbariServer:819 - Failed to run the Ambari Server
com.google.inject.ProvisionException: Guice provision errors:

1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
  at org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:243)
  at org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:125)
  while locating org.apache.ambari.server.api.services.AmbariMetaInfo
    for field at org.apache.ambari.server.controller.AmbariServer.ambariMetaInfo(AmbariServer.java:145)
  at org.apache.ambari.server.controller.AmbariServer.class(AmbariServer.java:145)
  while locating org.apache.ambari.server.controller.AmbariServer

1 error
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
        at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
        at org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:812)
Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.


Analisys:
According to exception it seems like Eclipselink initialize some data prior to database version check.
We should ensure db version check is first DB interaction of Ambari.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cc69134 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 4839d21 
  ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 03d3661 

Diff: https://reviews.apache.org/r/41771/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 41771: Database version check doesn't work in case of existing database from older Ambari version

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41771/
-----------------------------------------------------------

(Updated Дек. 29, 2015, 1:12 п.п.)


Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.


Bugs: AMBARI-14517
    https://issues.apache.org/jira/browse/AMBARI-14517


Repository: ambari


Description
-------

Issue created on base of Apache user group conversation.
STR:
install Ambari 2.0
deploy cluster
remove ambari rpm and install Ambari 2.2 (do NOT do upgrade)
Expected result:
Database version check should throw exception about incompatible db version.

Actual result:
Guice provision exception is thrown:
26 Dec 2015 10:57:46,911 ERROR [main] AmbariServer:819 - Failed to run the Ambari Server
com.google.inject.ProvisionException: Guice provision errors:

1) Error injecting method, Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.
  at org.apache.ambari.server.api.services.AmbariMetaInfo.init(AmbariMetaInfo.java:243)
  at org.apache.ambari.server.api.services.AmbariMetaInfo.class(AmbariMetaInfo.java:125)
  while locating org.apache.ambari.server.api.services.AmbariMetaInfo
    for field at org.apache.ambari.server.controller.AmbariServer.ambariMetaInfo(AmbariServer.java:145)
  at org.apache.ambari.server.controller.AmbariServer.class(AmbariServer.java:145)
  while locating org.apache.ambari.server.controller.AmbariServer

1 error
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
        at com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1013)
        at org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:812)
Caused by: Exception [EclipseLink-4011] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Exception Description: Error preallocating sequence numbers.  The sequence table information is not complete.


Analisys:
According to exception it seems like Eclipselink initialize some data prior to database version check.
We should ensure db version check is first DB interaction of Ambari.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cf7194c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java c4a4e4c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java 03d3661 

Diff: https://reviews.apache.org/r/41771/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen