You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/16 11:42:10 UTC
[GitHub] [ozone] sodonnel opened a new pull request #3098: HDDS-6331. Remove toString in debug log parameters within SCMCommonPlacementPolicy
sodonnel opened a new pull request #3098:
URL: https://github.com/apache/ozone/pull/3098
## What changes were proposed in this pull request?
The debug log has "toString()" called on datanode details, which means it must be evaluated before it gets passed into the debug logger. That means this string will always get created even when the log messages is not emitted.
```
LOG.debug("Datanode {} is chosen. Required metadata size is {} and " +
"required data size is {}",
datanodeDetails.toString(), metadataSizeRequired, dataSizeRequired);
```
We can just drop the toString part to fix this.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6331
## How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #3098: HDDS-6331. Remove toString in debug log parameters within SCMCommonPlacementPolicy
Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #3098:
URL: https://github.com/apache/ozone/pull/3098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org