You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by ma...@apache.org on 2026/04/16 11:38:00 UTC
(nifi-minifi-cpp) branch main updated: MINIFICPP-2783 - Remove unused global (#2159)
This is an automated email from the ASF dual-hosted git repository.
martinzink pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
The following commit(s) were added to refs/heads/main by this push:
new a3394382c MINIFICPP-2783 - Remove unused global (#2159)
a3394382c is described below
commit a3394382c649b5d41ff1ec04737e8f2d54e881f1
Author: Adam Debreceni <64...@users.noreply.github.com>
AuthorDate: Thu Apr 16 13:37:54 2026 +0200
MINIFICPP-2783 - Remove unused global (#2159)
---
libminifi/include/core/extension/ExtensionManager.h | 2 --
libminifi/src/core/extension/ExtensionManager.cpp | 12 ------------
2 files changed, 14 deletions(-)
diff --git a/libminifi/include/core/extension/ExtensionManager.h b/libminifi/include/core/extension/ExtensionManager.h
index 7b312ae4b..c610bd70a 100644
--- a/libminifi/include/core/extension/ExtensionManager.h
+++ b/libminifi/include/core/extension/ExtensionManager.h
@@ -37,8 +37,6 @@ class ExtensionManager {
ExtensionManager& operator=(const ExtensionManager&) = delete;
ExtensionManager& operator=(ExtensionManager&&) = delete;
- static Extension* getExtensionBeingInitialized();
-
private:
std::vector<std::unique_ptr<Extension>> extensions_;
diff --git a/libminifi/src/core/extension/ExtensionManager.cpp b/libminifi/src/core/extension/ExtensionManager.cpp
index 689a6cd42..e3c8d5032 100644
--- a/libminifi/src/core/extension/ExtensionManager.cpp
+++ b/libminifi/src/core/extension/ExtensionManager.cpp
@@ -30,16 +30,6 @@
namespace org::apache::nifi::minifi::core::extension {
-namespace {
-
-std::atomic<Extension*> extension_being_initialized{nullptr};
-
-} // namespace
-
-Extension* ExtensionManager::getExtensionBeingInitialized() {
- return extension_being_initialized.load();
-}
-
ExtensionManager::ExtensionManager(const std::shared_ptr<Configure>& config): logger_(logging::LoggerFactory<ExtensionManager>::getLogger()) {
logger_->log_trace("Initializing extensions");
if (!config) {
@@ -82,8 +72,6 @@ ExtensionManager::ExtensionManager(const std::shared_ptr<Configure>& config): lo
}
}
{
- auto extension_guard = gsl::finally([] {extension_being_initialized = nullptr;});
- extension_being_initialized = extension.get();
if (!extension->initialize(config)) {
logger_->log_error("Failed to initialize extension '{}' at '{}'", library->name, library->getFullPath());
} else {