You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sureshsubbiah <gi...@git.apache.org> on 2017/07/02 23:42:23 UTC
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
GitHub user sureshsubbiah opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1159
[TRAFODION-2674] Create index sees error 2006 internal assertion
RangePartitionFunction was missing region boundaries for indexes and using table's
boundaries incorrectly
Turned OFF OPT_PCODE_CACHE to avoid mem leak.
Unrelated testware change for compGeneral/TEST023
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshsubbiah/incubator-trafodion 3403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1159
----
commit f47c26136d70b275d14a97e8b9cd1cacb3d6dedd
Author: Suresh Subbiah <su...@apache.org>
Date: 2017-07-02T20:59:25Z
[TRAFODION-2674] Create index sees error 2006 internal assertion
RangePartitionFunction was missing region boundaries for indexes and using table's
boundaries incorrectly
Turned OFF OPT_PCODE_CACHE to avoid mem leak.
Unrelated testware change for compGeneral/TEST023
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1159#discussion_r125329545
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -2839,7 +2839,7 @@ SDDkwd__(ISO_MAPPING, (char *)SQLCHARSETSTRING_ISO88591),
DD_____(PCODE_DEBUG_LOGDIR, "" ), // Pathname of log directory for PCode work
DDint__(PCODE_EXPR_CACHE_CMP_ONLY, "0" ), // PCode Expr Cache compare-only mode
DDint__(PCODE_EXPR_CACHE_DEBUG, "0" ), // PCode Expr Cache debug (set to 1 to enable dbg logging)
- DDint__(PCODE_EXPR_CACHE_ENABLED, "1" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
+ DDint__(PCODE_EXPR_CACHE_ENABLED, "0" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
--- End diff --
On EXPECTED023, I was trying to change the text of an error message which incorrectly had the default schema as SEABASE instead of SCH. But I think that change had already been made (between the time I checked out and created this PR). Instead of my actual change, these DIFFs now show all the timestamp differences that are likely handled by the FILTER? I was not aware of the issue in HSTable::makeSampleName. Thank you for explaining.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1159#discussion_r125332529
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -2839,7 +2839,7 @@ SDDkwd__(ISO_MAPPING, (char *)SQLCHARSETSTRING_ISO88591),
DD_____(PCODE_DEBUG_LOGDIR, "" ), // Pathname of log directory for PCode work
DDint__(PCODE_EXPR_CACHE_CMP_ONLY, "0" ), // PCode Expr Cache compare-only mode
DDint__(PCODE_EXPR_CACHE_DEBUG, "0" ), // PCode Expr Cache debug (set to 1 to enable dbg logging)
- DDint__(PCODE_EXPR_CACHE_ENABLED, "1" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
+ DDint__(PCODE_EXPR_CACHE_ENABLED, "0" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
--- End diff --
Right. That was my screw-up. I had run compGeneral/TEST023 without running core/TEST000 first, which sets the default schema. I had fixed that issue, but the non-determinism in sample table name still causes random failures due to the line wrap issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1159#discussion_r125328798
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -2839,7 +2839,7 @@ SDDkwd__(ISO_MAPPING, (char *)SQLCHARSETSTRING_ISO88591),
DD_____(PCODE_DEBUG_LOGDIR, "" ), // Pathname of log directory for PCode work
DDint__(PCODE_EXPR_CACHE_CMP_ONLY, "0" ), // PCode Expr Cache compare-only mode
DDint__(PCODE_EXPR_CACHE_DEBUG, "0" ), // PCode Expr Cache debug (set to 1 to enable dbg logging)
- DDint__(PCODE_EXPR_CACHE_ENABLED, "1" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
+ DDint__(PCODE_EXPR_CACHE_ENABLED, "0" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
--- End diff --
Yes @DaveBirdsall . JIRA 2179 tracks this problem. I am sorry for not explaining this in the checkin message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1159#discussion_r125312113
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -2839,7 +2839,7 @@ SDDkwd__(ISO_MAPPING, (char *)SQLCHARSETSTRING_ISO88591),
DD_____(PCODE_DEBUG_LOGDIR, "" ), // Pathname of log directory for PCode work
DDint__(PCODE_EXPR_CACHE_CMP_ONLY, "0" ), // PCode Expr Cache compare-only mode
DDint__(PCODE_EXPR_CACHE_DEBUG, "0" ), // PCode Expr Cache debug (set to 1 to enable dbg logging)
- DDint__(PCODE_EXPR_CACHE_ENABLED, "1" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
+ DDint__(PCODE_EXPR_CACHE_ENABLED, "0" ), // PCode Expr Cache Enabled (set to 0 to disable the cache)
--- End diff --
Is the idea here that there is a memory leak in the PCODE cache that we intend to track down later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---