You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 12:13:14 UTC

[GitHub] [airflow] ashb edited a comment on issue #13513: Switch external actions to subrepo'ed .github/actions/

ashb edited a comment on issue #13513:
URL: https://github.com/apache/airflow/issues/13513#issuecomment-755264195


   Reading https://github.community/t/github-action-defined-as-submodule-in-a-repo/139204/12 it looks like we can use git submodules for actions so long as ASF have allowed us to use official actions, which I think they have.
   
   Thoughts on submodules here @potiuk?
   
   The main reason I'd prefer submodules over subrepo here is number of commits: having all the commit history for all the actions in our repo is "noisy", and coupuled with this only being used on CI everyone can basically ignore the fact we are using submodules -- development will happily work fine without them existing.
   
   So I guess I do have an opinion: no to subrepo or anything else that brings the commits for the actions in to our repo and "pollutes" our git history.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org