[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3779: [CARBONDATA-3835] Fix global sort string comparator issue

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3779:
URL: https://github.com/apache/carbondata/pull/3779#discussion_r432825992



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
##########
@@ -237,10 +238,18 @@ object DataLoadProcessBuilderOnSpark {
         CarbonProperties.getInstance().getGlobalSortRddStorageLevel()))
     }
     val sortColumnsLength = model.getCarbonDataLoadSchema.getCarbonTable.getSortColumns.size()
-    val sortColumnDataTypes = dataTypes.take(sortColumnsLength)
+    var sortColumnDataTypes = dataTypes.take(sortColumnsLength)
+    sortColumnDataTypes = sortColumnDataTypes.map { datatype =>
+      val updatedType = datatype match {
+        case StringType => ByteType
+        case TimestampType | DateType => LongType
+        case _ => datatype
+      }
+      updatedType
+    }

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org