You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stormcrawler.apache.org by "mvolikas (via GitHub)" <gi...@apache.org> on 2026/01/11 16:24:36 UTC
[PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
mvolikas opened a new pull request, #1776:
URL: https://github.com/apache/stormcrawler/pull/1776
Fixes #1775
Notes:
Most differences are whitespace.
We might also want to adjust the readme so that we include the commands to check via checkstyle and edditorconfig:
```
# check with checkstyle and generate reports under /target
mvn checkstyle:check
# check with edditorconfig
mvn validate
# format via edditorconfig plugin
mvn editorconfig:format
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776#issuecomment-3796903014
@mvolikas Thanks for the response(s)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776#issuecomment-3735170415
Lgtm.
- How does checkstyle format interact with the formatting plugin in place?
- Would it make sense to add an action similar to license for fixing intendition if missed or broken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "mvolikas (via GitHub)" <gi...@apache.org>.
mvolikas commented on PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776#issuecomment-3796871126
> Would it make sense to add an action similar to license for fixing indentation if missed or broken?
I don't think so, because the build fails in case there are `.editorconfig` violations, and you are prompted to auto-fix them.
e.g.:
```
[ERROR] Failed to execute goal org.ec4j.maven:editorconfig-maven-plugin:0.2.0:check (check) on project stormcrawler:
[ERROR]
[ERROR] There are .editorconfig violations. You may want to run
[ERROR]
[ERROR] mvn editorconfig:format
[ERROR]
[ERROR] to fix them automagically.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776#issuecomment-3796902440
I think we can bring this in once we are on 3.5.2-SNAPSHOT on main :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #1775 add indentation rules, fix inconsistent files [stormcrawler]
Posted by "mvolikas (via GitHub)" <gi...@apache.org>.
mvolikas commented on PR #1776:
URL: https://github.com/apache/stormcrawler/pull/1776#issuecomment-3796867926
> How does checkstyle format interact with the formatting plugin in place?
We currently have 3 formatting related plugins
1. Checkstyle (`maven-checkstyle-plugin`)
- Configuration from `checkstyle.xml`
- Only reports violations as warnings
- Validates multiple code quality rules (e.g., naming conventions)
- Mostly Java files
2. EditorConfig (`editorconfig-maven-plugin`)
- Checks indentation and whitespace for different file types
- Build fails on violations
- Can auto-fix violations with `editorconfig:format`
3. Git code format (`git-code-format-maven-plugin`)
- Disabled by default
- Recommended to run before submitting a PR
- Validation included in CI
- Java files only and very opinionated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org