[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7168: GEODE-9866: Improvements to AbstractRedisMemoryStatsIntegrationTest

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7168:
URL: https://github.com/apache/geode/pull/7168#discussion_r763438465



##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/server/AbstractRedisMemoryStatsIntegrationTest.java
##########
@@ -70,24 +67,13 @@ public void memoryFragmentationRatio_shouldBeGreaterThanZero() {
 
   @Test
   public void usedMemory_shouldIncrease_givenAdditionalValuesAdded() {
-    Map<String, String> addedData = makeHashMap(100_000, "field", "value");
-
     long initialUsedMemory = Long.parseLong(RedisTestHelper.getInfo(jedis).get(USED_MEMORY));
-
-    jedis.hset(EXISTING_HASH_KEY, addedData);
+    for (int i = 0; i < 500_000; i++) {

Review comment:
       would it be better to do even more than 500,000 but to check after each set if usedMemory is greater than initialUsedMemory. As soon as you see it > you could break out of the loop. This might make it less likely to be flakey.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org