You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2014/05/17 10:17:15 UTC
[jira] [Comment Edited] (ISIS-781) Add edit capability to view
objects
[ https://issues.apache.org/jira/browse/ISIS-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998522#comment-13998522 ]
Dan Haywood edited comment on ISIS-781 at 5/17/14 8:17 AM:
-----------------------------------------------------------
Related to this, Jeroen and I have been talking about maybe changing the Wicket viewer so that it works a bit like JIRA ... only allow a single field to be updated at a time. I've raised ISIS-784 for this.
If this was done, then potentially quite a lot of code in Wicket viewer might simplify... I'm thinking that much of the current edit stuff could go and instead use the existing code for invoking actions.
One of the side-effects of such a refactoring is that we would inherit the ability that the result of the action/edit could be a different object.
How that relates to this is that, although it would seem that the view model object is mutable, in fact the user would be looking at a new object that has taken the place of the original.
was (Author: danhaywood):
Related to this, Jeroen and I have been talking about maybe changing the Wicket viewer so that it works a bit like JIRA ... only allow a single field to be updated at a time.
If this was done, then potentially quite a lot of code in Wicket viewer might simplify... I'm thinking that much of the current edit stuff could go and instead use the existing code for invoking actions.
One of the side-effects of such a refactoring is that we would inherit the ability that the result of the action/edit could be a different object.
How that relates to this is that, although it would seem that the view model object is mutable, in fact the user would be looking at a new object that has taken the place of the original.
> Add edit capability to view objects
> -----------------------------------
>
> Key: ISIS-781
> URL: https://issues.apache.org/jira/browse/ISIS-781
> Project: Isis
> Issue Type: Improvement
> Components: Core
> Affects Versions: core-1.4.0
> Reporter: David Tildesley
> Assignee: Dan Haywood
> Fix For: viewer-wicket-1.5.0
>
>
> View object should have the same capability as domain object in the viewer. Currently it does not support "edit". Without this capability, actions must be employed and state management becomes more of an issue on the server side.
> The view object should support all of the viewer specific semantics that the domain objects support via the viewer generation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: [jira] [Comment Edited] (ISIS-781) Add edit capability to view objects
Posted by GESCONSULTOR - Óscar Bou <o....@gesconsultor.com>.
It seems ok to me also.
Currently, if you want to execute business logic when changing a field's value, it usually impacts on the UI as there's an associated action and the field is marked as @Disabled.
It was not so common to write the business logic on a modifyXXX method.
It's true that the entity must be fully "refreshed" as its properties could be changed due to action's or modifyXXX behavior (at least for those with a modifyXXX method; for those with a simple setXXX method perhaps is safe to assume that only that field has changed, so the "refresh" option can be avoided if simply the entered value is preserved).
El 17/05/2014, a las 10:17, Dan Haywood (JIRA) <ji...@apache.org> escribió:
>
> [ https://issues.apache.org/jira/browse/ISIS-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998522#comment-13998522 ]
>
> Dan Haywood edited comment on ISIS-781 at 5/17/14 8:17 AM:
> -----------------------------------------------------------
>
> Related to this, Jeroen and I have been talking about maybe changing the Wicket viewer so that it works a bit like JIRA ... only allow a single field to be updated at a time. I've raised ISIS-784 for this.
>
> If this was done, then potentially quite a lot of code in Wicket viewer might simplify... I'm thinking that much of the current edit stuff could go and instead use the existing code for invoking actions.
>
> One of the side-effects of such a refactoring is that we would inherit the ability that the result of the action/edit could be a different object.
>
> How that relates to this is that, although it would seem that the view model object is mutable, in fact the user would be looking at a new object that has taken the place of the original.
>
>
> was (Author: danhaywood):
> Related to this, Jeroen and I have been talking about maybe changing the Wicket viewer so that it works a bit like JIRA ... only allow a single field to be updated at a time.
>
> If this was done, then potentially quite a lot of code in Wicket viewer might simplify... I'm thinking that much of the current edit stuff could go and instead use the existing code for invoking actions.
>
> One of the side-effects of such a refactoring is that we would inherit the ability that the result of the action/edit could be a different object.
>
> How that relates to this is that, although it would seem that the view model object is mutable, in fact the user would be looking at a new object that has taken the place of the original.
>
>> Add edit capability to view objects
>> -----------------------------------
>>
>> Key: ISIS-781
>> URL: https://issues.apache.org/jira/browse/ISIS-781
>> Project: Isis
>> Issue Type: Improvement
>> Components: Core
>> Affects Versions: core-1.4.0
>> Reporter: David Tildesley
>> Assignee: Dan Haywood
>> Fix For: viewer-wicket-1.5.0
>>
>>
>> View object should have the same capability as domain object in the viewer. Currently it does not support "edit". Without this capability, actions must be employed and state management becomes more of an issue on the server side.
>> The view object should support all of the viewer specific semantics that the domain objects support via the viewer generation.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
Óscar Bou Bou
Responsable de Producto
Auditor Jefe de Certificación ISO 27001 en BSI
CISA, CRISC, APMG ISO 20000, ITIL-F
902 900 231 / 620 267 520
http://www.twitter.com/oscarbou
http://es.linkedin.com/in/oscarbou
http://www.GesConsultor.com
Este mensaje y los ficheros anexos son confidenciales. Los mismos contienen información reservada que no puede ser difundida. Si usted ha recibido este correo por error, tenga la amabilidad de eliminarlo de su sistema y avisar al remitente mediante reenvío a su dirección electrónica; no deberá copiar el mensaje ni divulgar su contenido a ninguna persona.
Su dirección de correo electrónico junto a sus datos personales constan en un fichero titularidad de Gesdatos Software, S.L. cuya finalidad es la de mantener el contacto con Ud. Si quiere saber de qué información disponemos de Ud., modificarla, y en su caso, cancelarla, puede hacerlo enviando un escrito al efecto, acompañado de una fotocopia de su D.N.I. a la siguiente dirección: Gesdatos Software, S.L. , Paseo de la Castellana, 153 bajo - 28046 (Madrid), y Avda. Cortes Valencianas num. 50, 1ºC - 46015 (Valencia). Asimismo, es su responsabilidad comprobar que este mensaje o sus archivos adjuntos no contengan virus informáticos, y en caso que los tuvieran eliminarlos.