You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/07/09 22:26:33 UTC
[GitHub] [tomcat] ekkelenkamp opened a new pull request #432: Allow subclassing CorsFilter getAllowedOrigins() and isAnyOriginAllow…
ekkelenkamp opened a new pull request #432:
URL: https://github.com/apache/tomcat/pull/432
I would like to be able to subclass the CorsFilter clases to be able to provide a custom list of allowed origins, instead of configure them from the init parameters. This will allow providing the allowedOrigins at runtime and not hardcoded in the web.xml init parameters.
Unfortunately the method **isOriginAllowed** uses the instance variable allowedOrigns directly. This makes it impossible to override the available function: getAllowedOrigins and isAnyOriginAllowed.
See also:
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #432: Allow subclassing CorsFilter getAllowedOrigins() and isAnyOriginAllow…
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #432:
URL: https://github.com/apache/tomcat/pull/432#issuecomment-886825945
I went a little further and ensured getters were used for all configurable fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #432: Allow subclassing CorsFilter getAllowedOrigins() and isAnyOriginAllow…
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #432:
URL: https://github.com/apache/tomcat/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org