You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2024/09/11 22:08:00 UTC
[PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
jmuehlner opened a new pull request, #550:
URL: https://github.com/apache/guacamole-server/pull/550
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#issuecomment-2346983347
> > > Is there no way to automatically detect if the remote vnc server supports dimension changes?
> >
> >
> > In my research, there is no consistent way to detect support for it - there is no standard handshake or capabilities message between the client and the server that passes this information, it's just up to the client to try and the server to either respond by changing the display size or ignore the request.
>
> Sounds like there's not much left to do here, yeah? People will just have to disable VNC resizing for any server that can't handle the resize request.
Agreed. I'll merge this and we'll probably have to call it good, unless someone else comes up with a more reliable way to test for server-side support of resizing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#issuecomment-2346153955
>
> Is there no way to automatically detect if the remote vnc server supports dimension changes?
In my research, there is no consistent way to detect support for it - there is no standard handshake or capabilities message between the client and the server that passes this information, it's just up to the client to try and the server to either respond by changing the display size or ignore the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #550:
URL: https://github.com/apache/guacamole-server/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#issuecomment-2345680883
This partially fixes the issue I mentioned yesterday in the ticket.
With disable_display_resize checked, no more display problems, but without check disable_display_resize, I was disconnected instantly upon connection.
Is there no way to automatically detect if the remote vnc server supports dimension changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#discussion_r1755738981
##########
src/protocols/vnc/display.c:
##########
@@ -51,16 +51,10 @@ void guac_vnc_update(rfbClient* client, int x, int y, int w, int h) {
guac_client* gc = rfbClientGetClientData(client, GUAC_VNC_CLIENT_KEY);
guac_vnc_client* vnc_client = (guac_vnc_client*) gc->data;
-#ifdef LIBVNC_CLIENT_HAS_SCREEN
- int new_height = rfbClientSwap16IfLE(client->screen.height);
- int new_width = rfbClientSwap16IfLE(client->screen.width);
-#else
- int new_height = rfbClientSwap16IfLE(client->height);
Review Comment:
This was wrong anyway - the bit swap should not happen on the client height and width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1196: Read VNC dimensions directly from the client, not the screen. [guacamole-server]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#issuecomment-2346907346
> > Is there no way to automatically detect if the remote vnc server supports dimension changes?
>
> In my research, there is no consistent way to detect support for it - there is no standard handshake or capabilities message between the client and the server that passes this information, it's just up to the client to try and the server to either respond by changing the display size or ignore the request.
Sounds like there's not much left to do here, yeah? People will just have to disable VNC resizing for any server that can't handle the resize request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org