You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2013/06/10 22:58:21 UTC

[jira] [Commented] (CASSANDRA-5623) Cleanup interruption handling

    [ https://issues.apache.org/jira/browse/CASSANDRA-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679900#comment-13679900 ] 

Dave Brosius commented on CASSANDRA-5623:
-----------------------------------------

This changes the semantics of what was going on. I can see using Futures.getUnchecked etc, to clean the code up some. I'm not sure I understand the intention of this patch, as it makes this non interruptable, which is completely different, and to me seems wrong. But perhaps it went over my head.
                
> Cleanup interruption handling
> -----------------------------
>
>                 Key: CASSANDRA-5623
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5623
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Mikhail Mazursky
>            Assignee: Mikhail Mazursky
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: trunk-5623.txt
>
>
> There are a lot of catch-wrap-throw pattern occurances in code with InterruptedException. I cleaned up some of them but not all - in some places I don't know enough about code to decide if it's correct thing to do.
> Important: I also fixed possibility of wrong behaviour in case of spurious wakeup in AsyncOneResponse.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira