[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361061471
 
 

 ##########
 File path: solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java
 ##########
 @@ -275,7 +276,7 @@ private VelocityContext createContext(SolrQueryRequest request, SolrQueryRespons
         for (Map.Entry<String, String> entry : customTools.entrySet()) {
           String name = entry.getKey();
           // TODO: at least log a warning when one of the *fixed* tools classes is same name with a custom one, currently silently ignored
-          Object customTool = SolrCore.createInstance(entry.getValue(), Object.class, "VrW custom tool: " + name, request.getCore(), request.getCore().getResourceLoader());
+          Object customTool = SolrCore.newInstance(new PluginInfo(name, entry.getValue()), Object.class, request.getCore(), request.getCore().getResourceLoader());
 
 Review comment:
   I'll add a code review comment over on that method in SolrCore so we can discuss it in context; I renamed it.  What is the correct classloader it should use?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org