You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/07 06:16:25 UTC
[GitHub] [superset] spookymotion opened a new issue #13504: Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id
spookymotion opened a new issue #13504:
URL: https://github.com/apache/superset/issues/13504
The method check_dashboard_access tries to access `str(kwargs["dashboard_id_or_slug"]` which results in a KeyError if the user was redirected from /welcome
### Expected results
No KeyError, and user is directed to their welcome_dashboard_id
### Actual results
A KeyError
#### Screenshots
<img width="1104" alt="Screen Shot 2021-03-07 at 1 15 19 AM" src="https://user-images.githubusercontent.com/669053/110230965-afad2200-7ee2-11eb-910f-25f7fd9fa8ca.png">
#### How to reproduce the bug
Add a row to UserAttribute linking User ID X with welcome_dashboard_id Y
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed issue #13504: Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed issue #13504:
URL: https://github.com/apache/superset/issues/13504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] spookymotion commented on issue #13504: Introduction of dashboard_rbac broke user_attribute welcome_dashboard_id
Posted by GitBox <gi...@apache.org>.
spookymotion commented on issue #13504:
URL: https://github.com/apache/superset/issues/13504#issuecomment-792303123
Fixed by https://github.com/apache/superset/pull/13505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org