[GitHub] [spark] gengliangwang commented on a diff in pull request #40749: SPARK-43100 Mismatch of field name in log event writer and parser for push shuffle metrics

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on code in PR #40749:
URL: https://github.com/apache/spark/pull/40749#discussion_r1163445642


##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -545,7 +545,7 @@ private[spark] object JsonProtocol {
       g.writeNumberField("Total Records Read", taskMetrics.shuffleReadMetrics.recordsRead)
       g.writeNumberField("Remote Requests Duration",
         taskMetrics.shuffleReadMetrics.remoteReqsDuration)
-      g.writeFieldName("Push Based Shuffle")
+      g.writeFieldName("Shuffle Push Read Metrics")

Review Comment:
   Shall we use a constant string instead of hard coding it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org