You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/09/02 07:23:51 UTC
[GitHub] zeppelin pull request #1395: [ZEPPELIN-1404] invalid html structure for boot...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1395
[ZEPPELIN-1404] invalid html structure for bootstrap in interpreter setting page
### What is this PR for?
invalid html structure for bootstrap in interpreter setting page.
for example :
correct
```html
<div class="row">
<div class="col-md-12">
</div>
</div>
```
invalid now.
```html
<div class="row">
<div class="col-md-12">
</div>
</div>
<div class="col-md-12">
</div>
```
There occurs a problem with the current designers, and shape.
Please, check to Screenshots in this pr.
### What type of PR is it?
Bug Fix
### Todos
- [x] Fixed html structure
- [x] modification to margin for checkbox.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1404
### How should this be tested?
click to interpreter menu in web ui.
### Screenshots (if appropriate)
#### before wide screen.
#### after wide screen.
- active stripe table, and fixed margin, and other layout.
#### before mobile size screen
#### after mobile size screen
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin dev/interpreter-tag-fixed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1395
----
commit 771c9014e8e7b2b759aedafc885d84e37f89283a
Author: CloverHearts <cl...@gmail.com>
Date: 2016-09-02T07:12:31Z
fixed to correct html(bootstrap) syntax for interpreter setting page.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1395
@cloverhearts actually there is also the space of the dependencies section.
It would be better to simply modify the `table-striped` class. [at this line](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.css#L505)
I checked and that class is used only in a few cases (Credential, Configuration, Interpreter), and removing that space is making them look better)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1395
@corneadoug
Okay, i has fixed it.
1. removed style `table style="margin-top: 0px"`
2. remove margin-top css in paragraph.css
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1395: [ZEPPELIN-1404] invalid html structure for boot...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1395
Tested and it definitely looks better!
It's my personal preference, can we put more space between "Option" and the dropdown menu? It would be better "Options" and the dropdown menu has same gap with "Properties" and the below property table. I mean
<img src="https://cloud.githubusercontent.com/assets/10060731/18241497/6ecb441c-738c-11e6-90ae-ab05626716e5.png" width="360px">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1395
@AhyoungRyu Thank you for your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1395
fixed.
https://github.com/apache/zeppelin/pull/1395/commits/cd6db05768523071462457205b0fcf20fc4f7865
```
<table class="table table-striped" style="margin-top:0px;">
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1395
@corneadoug
rebase is done.
ci is green!
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1395
@cloverhearts Could you rebase this branch?
It should make the CI green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1395
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1395: [ZEPPELIN-1404] invalid html structure for bootstrap i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---