[GitHub] [arrow] nealrichardson commented on pull request #12849: ARROW-15092: [R] Support create_package_with_all_dependencies() on non-linux systems

[GitBox <gi...@apache.org>]

nealrichardson commented on PR #12849:
URL: https://github.com/apache/arrow/pull/12849#issuecomment-1095191610

   @karldw thanks for taking a stab at this and apologies for missing your earlier ping on jira (I get lots of jira notifications). From the error message reported on the issue, it looks like the problem is the call to `readlink` in the download_dependencies.sh script. Reading the man page for that, it looks like it exists only to resolve any symlinks that might be in the `DESTDIR`. I'm not sure why exactly (ARROW-4033 last edited this line; the change was initially added in #2673 with no discussion). Before adding all of this R code, I might try editing that line to
   
   ```
   DESTDIR=$(readlink -f "${DESTDIR}" || readlink "${DESTDIR}" || ${DESTDIR})
   ```
   
   (macOS has readlink but doesn't support -f; `|| ${DESTDIR}` because it probably doesn't matter anyway).
   
   In general I think trying to download_dependencies.sh work on more platforms is the right solution, rather than hacking around it in R.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org