You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/26 06:16:22 UTC
[GitHub] [flink] leonardBang opened a new pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
leonardBang opened a new pull request #13245:
URL: https://github.com/apache/flink/pull/13245
## What is the purpose of the change
* This pull request add `scan.query` option for dynamic JDBC connector.
## Brief change log
- introduce option `scan.query`
- use custom query first when scan a JDBC table
## Verifying this change
- Add unit test in `JdbcDynamicTableFactoryTest` and ITCase in `JdbcDynamicTableSourceITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e46b2611459d09da2c220cb3fe2e8658c930a78f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
leonardBang edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-685239670
> LGTM. It could be worth to mention in the documentation that when **scan.query** is present then **table-name** is ignored
Thanks @fpompermaier for the review very much.
I consider that a JDBC table can be source table and dimension table(lookup) at the same time, and the **table-name** is necessary when it used as dimension table not matter the **scan.query** is present or not.
So how about add an explanation for **scan.query** that if the **scan.query** option is present then **table-name** option is ignored when used as source table ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
}, {
"hash" : "4a0370f30701c680892ec0f934878b18142c742f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a0370f30701c680892ec0f934878b18142c742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e46b2611459d09da2c220cb3fe2e8658c930a78f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871)
* 4a0370f30701c680892ec0f934878b18142c742f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-685239670
> LGTM. It could be worth to mention in the documentation that when **scan.query** is present then **table-name** is ignored
Thanks @fpompermaier for the review very much.
I consider that a JDBC source table can be source table and dimension table(lookup) at the same time, and the **table-name** is necessary when it used as dimension table not matter the **scan.query** is present or not.
So how about add an explanation for **scan.query** that if the **scan.query** option is present then **table-name** option is ignored when used as source table ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e46b2611459d09da2c220cb3fe2e8658c930a78f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
}, {
"hash" : "4a0370f30701c680892ec0f934878b18142c742f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6077",
"triggerID" : "4a0370f30701c680892ec0f934878b18142c742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a0370f30701c680892ec0f934878b18142c742f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680682091
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e46b2611459d09da2c220cb3fe2e8658c930a78f (Wed Aug 26 06:18:23 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e46b2611459d09da2c220cb3fe2e8658c930a78f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tonychen0716 commented on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
tonychen0716 commented on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-743994579
Looking forward to this merger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13245:
URL: https://github.com/apache/flink/pull/13245#issuecomment-680688340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5871",
"triggerID" : "e46b2611459d09da2c220cb3fe2e8658c930a78f",
"triggerType" : "PUSH"
}, {
"hash" : "4a0370f30701c680892ec0f934878b18142c742f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6077",
"triggerID" : "4a0370f30701c680892ec0f934878b18142c742f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a0370f30701c680892ec0f934878b18142c742f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org