You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/29 20:14:21 UTC
[jira] [Commented] (BEAM-587) Update KafkaIO to take advantage of
Dofn Setup/Teardown
[ https://issues.apache.org/jira/browse/BEAM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446935#comment-15446935 ]
ASF GitHub Bot commented on BEAM-587:
-------------------------------------
GitHub user rangadi opened a pull request:
https://github.com/apache/incubator-beam/pull/904
[BEAM-587] take advantage of setup/teardown for KafkaWriter
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rangadi/incubator-beam setup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #904
----
commit e578045b73e8500a287a966d544e14ea2f620cb5
Author: Raghu Angadi <ra...@google.com>
Date: 2016-08-29T20:09:58Z
take advantage of setup/teardown for KafkaWriter
----
> Update KafkaIO to take advantage of Dofn Setup/Teardown
> -------------------------------------------------------
>
> Key: BEAM-587
> URL: https://issues.apache.org/jira/browse/BEAM-587
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Daniel Halperin
> Assignee: Raghu Angadi
>
> Now that [~tgroh] has implemented DoFn setup/teardown in all runners, we should make KafkaIO/write's pardo only create the producer once in setup rather than in startBundle. Should be a huge efficiency win!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)