[GitHub] [avro] martin-g commented on a diff in pull request #1863: AVRO-3628: [Java] JUnit 4.x tests are not executed

[GitBox <gi...@apache.org>]

martin-g commented on code in PR #1863:
URL: https://github.com/apache/avro/pull/1863#discussion_r969477369


##########
lang/java/maven-plugin/pom.xml:
##########
@@ -60,6 +60,7 @@
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
       <version>${maven-core.version}</version>
+      <scope>provided</scope>

Review Comment:
   This fixes the following Maven error:
   ```
   [INFO] --- maven-plugin-plugin:3.6.4:helpmojo (generated-helpmojo) @ avro-maven-plugin ---
   [ERROR] 
   
   Some dependencies of Maven Plugins are expected to be in provided scope.
   Please make sure that dependencies listed below declared in POM
   have set '<scope>provided</scope>' as well.
   
   The following dependencies are in wrong scope:
    * org.apache.maven:maven-core:jar:3.3.9:compile
    * org.apache.maven:maven-model:jar:3.3.9:compile
    * org.apache.maven:maven-settings:jar:3.3.9:compile
    * org.apache.maven:maven-settings-builder:jar:3.3.9:compile
    * org.apache.maven:maven-builder-support:jar:3.3.9:compile
    * org.apache.maven:maven-repository-metadata:jar:3.3.9:compile
    * org.apache.maven:maven-artifact:jar:3.3.9:compile
    * org.apache.maven:maven-plugin-api:jar:3.3.9:compile
    * org.apache.maven:maven-model-builder:jar:3.3.9:compile
    * org.apache.maven:maven-aether-provider:jar:3.3.9:compile
   ```



##########
lang/java/maven-plugin/src/test/resources/unit/idl/pom-injecting-velocity-tools.xml:
##########
@@ -22,7 +22,7 @@
   <parent>
     <artifactId>avro-parent</artifactId>
     <groupId>org.apache.avro</groupId>
-    <version>1.11.0-SNAPSHOT</version>
+    <version>1.12.0-SNAPSHOT</version>

Review Comment:
   It seems something is wrong with the release process. Several pom.xml files were still pointing to the old 1.11.0-SNAPSHOT parent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org