[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412698#comment-15412698 ] 

ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------

Github user tpcwang commented on the issue:

    https://github.com/apache/thrift/pull/1044
  
    I didn't review the changes in detail, but I agree with the change and like the fact that we can compile cleanly with /W3 :+1: 


> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
>                 Key: THRIFT-3873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3873
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>         Environment: VS2010, Windows
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)