You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Hongshun Wang (Jira)" <ji...@apache.org> on 2023/02/24 06:39:00 UTC
[jira] [Updated] (FLINK-31208) KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)

     [ https://issues.apache.org/jira/browse/FLINK-31208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hongshun Wang updated FLINK-31208:
----------------------------------
    Description: 
KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) ，which is no difference with its Parent class (SourceReaderBase). why not remove this override method?

 

Relative code is here, which we can see is no difference?
{code:java}
//org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
} 

//org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
}{code}

  was:
KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) ，because no difference with its Parent class (SourceReaderBase). why not remove this override method?

 

Relative code is here, which we can see is no difference?
{code:java}
//org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
} 

//org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
}{code}


> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-31208
>                 URL: https://issues.apache.org/jira/browse/FLINK-31208
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka
>            Reporter: Hongshun Wang
>            Priority: Not a Priority
>
> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) ，which is no difference with its Parent class (SourceReaderBase). why not remove this override method?
>  
> Relative code is here, which we can see is no difference?
> {code:java}
> //org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
>         Collection<String> splitsToPause, Collection<String> splitsToResume) {
>     splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> } 
> //org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
>         Collection<String> splitsToPause, Collection<String> splitsToResume) {
>     splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)