You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/01/06 14:56:11 UTC

[GitHub] [logging-log4j2] vy commented on pull request #454: LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.

vy commented on pull request #454:
URL: https://github.com/apache/logging-log4j2/pull/454#issuecomment-755346186


   Hey @carterkozak, thanks so much for taking time to review the changes and going even further to implement an alternative approach. I am not inclined the go with a new template resolver to resolve the actual template. This is sort of a *meta* directive which I am hesitant to introduce, unless there is a use case that I fail to see.
   
   @carterkozak, may I assume you are okay with my changes? If so, I am gonna merge them to both `release-2.x` and `master`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org