You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 03:24:32 UTC

[jira] [Created] (BOOKKEEPER-94) BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.

BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.
------------------------------------------------------------------

                 Key: BOOKKEEPER-94
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
             Project: Bookkeeper
          Issue Type: Bug
    Affects Versions: 3.4.0
            Reporter: Sijie Guo
            Assignee: Sijie Guo


BookieReadWriteTest#testReadFromOpenLedger, but the @Test annotation is missing from it so it never gets run. Also, the actual checking code seems to be wrong, as it tries to read from lh, not lhOpen (line 861)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-94) BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.

Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-94:
--------------------------------

    Attachment: bookkeeper-94_v2.patch
    
> BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.
> ------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-94
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: bookkeeper-94.patch, bookkeeper-94_v2.patch
>
>
> BookieReadWriteTest#testReadFromOpenLedger, but the @Test annotation is missing from it so it never gets run. Also, the actual checking code seems to be wrong, as it tries to read from lh, not lhOpen (line 861)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-94) Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.

Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-94:
--------------------------------

    Component/s: bookkeeper-server
    Description: As comment in [BOOKKEEPER-93 | https://issues.apache.org/jira/browse/BOOKKEEPER-93], double callbacks happen even it success callback receiving enough valid responses.  (was: BookieReadWriteTest#testReadFromOpenLedger, but the @Test annotation is missing from it so it never gets run. Also, the actual checking code seems to be wrong, as it tries to read from lh, not lhOpen (line 861))
        Summary: Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.  (was: BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.)
    
> Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-94
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 3.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: bookkeeper-94.patch, bookkeeper-94_v2.patch
>
>
> As comment in [BOOKKEEPER-93 | https://issues.apache.org/jira/browse/BOOKKEEPER-93], double callbacks happen even it success callback receiving enough valid responses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-94) BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.

Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-94:
--------------------------------

    Attachment: bookkeeper-94.patch
    
> BookieReadWriteTest#testReadFromOpenLedger doesn't work correctly.
> ------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-94
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: bookkeeper-94.patch
>
>
> BookieReadWriteTest#testReadFromOpenLedger, but the @Test annotation is missing from it so it never gets run. Also, the actual checking code seems to be wrong, as it tries to read from lh, not lhOpen (line 861)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-94) Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.

Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-94:
--------------------------------

    Attachment: bookkeeper-94_v3.patch

check whether the operation is completed or not when callback.
also change *notComplete* to *completed* and using condition *!completed*.

since we have BookieReadWriteTest#testLastConfirmedAdd / BookieReadWriteTest#testReadOpenLedger for readLastConfirmed, no new test cases will be added.
                
> Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-94
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 3.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: bookkeeper-94.patch, bookkeeper-94_v2.patch, bookkeeper-94_v3.patch
>
>
> As comment in [BOOKKEEPER-93 | https://issues.apache.org/jira/browse/BOOKKEEPER-93], double callbacks happen even it success callback receiving enough valid responses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-94) Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.

Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135962#comment-13135962 ] 

Ivan Kelly commented on BOOKKEEPER-94:
--------------------------------------

BookieReadWriteTest#testLastConfirmedAdd is failing on trunk due to this issue.

                
> Double callbacks in readLastConfirmedOp which fails readLastConfirmed operation even received enough valid responses.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-94
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-94
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 3.4.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>         Attachments: bookkeeper-94.patch, bookkeeper-94_v2.patch
>
>
> As comment in [BOOKKEEPER-93 | https://issues.apache.org/jira/browse/BOOKKEEPER-93], double callbacks happen even it success callback receiving enough valid responses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira