[GitHub] [hive] jcamachor commented on a change in pull request #1847: HIVE-24613: Support Values clause without Insert

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #1847:
URL: https://github.com/apache/hive/pull/1847#discussion_r555534669



##########
File path: ql/src/test/queries/clientpositive/values.q
##########
@@ -0,0 +1,10 @@
+set hive.cli.print.header=true;
+

Review comment:
       Can we add `explain cbo` for some of these queries?

##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g
##########
@@ -306,7 +316,7 @@ valuesTableConstructor
 @init { gParent.pushMsg("values table constructor", state); }
 @after { gParent.popMsg(state); }
     :
-    valueRowConstructor (COMMA! valueRowConstructor)*
+    valueRowConstructor (options{greedy=true;}: COMMA! valueRowConstructor)*

Review comment:
       Can you leave a comment about the `greedy` option behavior?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org