You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/06/06 06:34:46 UTC

[GitHub] liubao68 commented on a change in pull request #745: [SCB-636] change config mapping machanism

liubao68 commented on a change in pull request #745: [SCB-636] change config mapping machanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/745#discussion_r193304812
 
 

 ##########
 File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
 ##########
 @@ -181,6 +183,14 @@ private static void duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
     compositeConfiguration.addConfiguration(source, sourceName);
   }
 
+  private static void duplicateServiceCombConfigToCseAtFront(ConcurrentCompositeConfiguration compositeConfiguration,
+      AbstractConfiguration source,
+      String sourceName) {
+    duplicateServiceCombConfigToCse(source);
 
 Review comment:
   duplicateServiceCombConfigToCse has already addConfiguration,  and here addConfigurationAtFront again, is it necessary to add it twice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services