[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9101: Fix handling of OPTIONS request

[GitBox <gi...@apache.org>]

cmcfarlen commented on code in PR #9101:
URL: https://github.com/apache/trafficserver/pull/9101#discussion_r981654188


##########
proxy/hdrs/HTTP.cc:
##########
@@ -1133,7 +1133,12 @@ http_parser_parse_req(HTTPParser *parser, HdrHeap *heap, HTTPHdrImpl *hh, const
     ink_assert(hh->u.req.m_url_impl != nullptr);
 
     url = hh->u.req.m_url_impl;
-    err = ::url_parse(heap, url, &url_start, url_end, must_copy_strings, strict_uri_parsing);
+    if (method_wks_idx == HTTP_WKSIDX_OPTIONS && url_end - url_start == 1 && url_start[0] == '*') {

Review Comment:
   Why do you use the magic `ASTERISK` value rather than just check for `*`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org