You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/03/28 16:47:44 UTC
Review Request 45384: GEODE-1134: Some scenarios loading cluster
config from dir do not work.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45384/
-----------------------------------------------------------
Review request for geode, Jinmei Liao and Kirk Lund.
Repository: geode
Description
-------
GEODE-1134: Some scenarios loading cluster config from dir do not work.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java 30a1da78975af7a5996fc0882fbbe108ffc7d62c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/cluster-empty.xml PRE-CREATION
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/cluster-region.xml PRE-CREATION
Diff: https://reviews.apache.org/r/45384/diff/
Testing
-------
New tests written
Thanks,
Jens Deppe
Re: Review Request 45384: GEODE-1134: Some scenarios loading cluster
config from dir do not work.
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45384/#review125641
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On March 28, 2016, 2:47 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45384/
> -----------------------------------------------------------
>
> (Updated March 28, 2016, 2:47 p.m.)
>
>
> Review request for geode, Jinmei Liao and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1134: Some scenarios loading cluster config from dir do not work.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java 30a1da78975af7a5996fc0882fbbe108ffc7d62c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java PRE-CREATION
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/cluster-empty.xml PRE-CREATION
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/cluster-region.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45384/diff/
>
>
> Testing
> -------
>
> New tests written
>
>
> Thanks,
>
> Jens Deppe
>
>